Thread (47 messages) flat view 47 messages, 5 authors, 2016-06-15

Re: [PATCH v4 3/4] setup: Add 'abspath_part_inside_repo' function

From: Torsten Bögershausen <hidden>
Date: 2016-06-15 22:59:47

quoted
Another comment:
The "raw" comparison with '/' is probably working well on all
POSIX/Linux/Unix systems.

To be more portable, the macro
is_dir_sep()
can be used:

if (is_dir_sep(path[wtlen]))
Since the path is already normalized by 'normalize_path_copy_len' which
seems to guarantee '/'-separation, I have assumed that this was
unnecessary?
So true, sorry for the noise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help