Thread (67 messages) flat view 67 messages, 8 authors, 2016-06-15
DORMANTno replies

[PATCH v2 0/3] unaligned reads from .bitmap files

From: Jeff King <hidden>
Date: 2016-06-15 22:59:44

On Thu, Jan 23, 2014 at 01:33:20PM -0500, Jeff King wrote:
Here's a patch series (on top of jk/pack-bitmap, naturally) that lets
t5310 pass there. I assume the ARM problem is the same, though seeing
the failure in realloc() is unexpected. Can you try it on both your
platforms with these patches?

  [1/2]: compat: move unaligned helpers to bswap.h
  [2/2]: ewah: support platforms that require aligned reads
Here it is again, fixing the issues we've discussed.

Instead of building on the code in read-cache, it pulls the much more
battle-tested code from block-sha1, and refactors read-cache to use that
instead. So the fix now kicks in automatically, and in theory it is a
slight bit faster (though I still doubt it would even be measurable in
this case).

  [1/3]: block-sha1: factor out get_be and put_be wrappers
  [2/3]: read-cache: use get_be32 instead of hand-rolled ntoh_l
  [3/3]: ewah: support platforms that require aligned reads

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help