Thread (7 messages) flat view 7 messages, 2 authors, 2016-06-15

Re: [PATCH 2/2] format-patch: introduce format.defaultTo

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:59:36

Jonathan Nieder wrote:
 1. Most config settings are in noun form: e.g.,
    "[remote] pushDefault = foo".  That makes their names easy to guess
    and makes them easy to talk about: I set the default remote for
    pushing by changing the remote.pushdefault setting.

    '[url "<foo>"] insteadOf' is an exception to that and a bit of an
    aberration.

    This new '[format] defaultTo' repeats the same end-with-a-preposition
    mistake, while I think it would be better to learn from it.
I agree that it's somewhat unconventional to allow people to put a
<revision> as a configuration variable value, but I think it's useful.
url.<url>.insteadOf is incredibly useful, for instance.
 2. Wouldn't a more natural default be @{u}..HEAD instead of relying on
    the user to do the make-work of keeping a local branch that tracks
    master up to date?
Like I said in my message to Junio, @{u} is not necessarily the "best"
default for all workflows, although you can fill that into
format.defaultTo.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help