Re: [PATCH 2/3] prune_object_dir(): verify that path fits in the temporary buffer

On Wed, Dec 18, 2013 at 12:07:02PM -0800, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

quoted

quoted

+			prune_object(path->buf, sha1);
+			path->len = baselen;

This is minor, but I prefer using strbuf_setlen() for this.

Good catch. I do not think it is minor at all; my version is buggy.
After the loop ends, path->len does not match the NUL in path->buf. That
is OK if the next caller is strbuf-aware, but if it were to pass
path->buf straight to a system call, that would be rather...confusing.

Hmph, rmdir(path->buf) at the end of prune_dir() may have that exact
issue.

Will squash in the following.

Thanks. Are you picking this up with a commit message, or did you want
me to re-send with the usual message/signoff?

-Peff