Re: [PATCH] git-svn: Support svn:global-ignores property
From: Eric Wong <hidden>
Date: 2016-06-15 22:59:28
Aleksey Vasenev [off-list ref] wrote:
---
What Thomas said about commit messages. Note: I hardly use git-svn or SVN anymore and don't pay attention to SVN changes. Some style nitpicks:
quoted hunk ↗ jump to hunk
@@ -1304,16 +1318,20 @@ sub cmd_create_ignore { # which git won't track mkpath([$path]) unless -d $path; my $ignore = $path . '.gitignore'; - my $s = $props->{'svn:ignore'} or return; + my $s = &get_svn_ignore($props, 'svn:ignore'); + my $s_global = &get_svn_ignore($props, 'svn:global-ignores');
&sub(...) convention isn't consistent with the rest of our Perl code. Do this instead: my $s = get_svn_ignore($props, 'svn:ignore'); my $s_global = get_svn_ignore($props, 'svn:global-ignores');
+ $s or $s_global or return;
Precedence should be more explicit: ($s || $s_global) or return; Likewise for cmd_show_ignore. Thanks.