Thread (40 messages) flat view 40 messages, 5 authors, 2016-06-15

Re: [PATCH v2 01/21] path.c: avoid PATH_MAX as buffer size from get_pathname()

From: Duy Nguyen <hidden>
Date: 2016-06-15 22:59:27

On Sun, Dec 15, 2013 at 3:35 PM, Torsten Bögershausen [off-list ref] wrote:
If we really want to go away from PATH_MAX, is a hard-coded value of 4096 so attractive ?
Because we can either

a) Re-define PATH_MAX in git-compat-util.h
b) Use an own  #define in git-compat-util.h, like e.g. GIT_PATH_MAX
c) Change the code to use a "strbuf" which can grow on demand.

I would prefer c) over b) over a)
Looking at the code again, c) looks feasible after updating
git_snpath() to accept a strbuf instead of buffer/size pair.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help