Re: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

John Szakmeister [off-list ref] writes:

On Mon, Dec 9, 2013 at 1:06 PM, Junio C Hamano [off-list ref] wrote:
[snip]

quoted

I thought we cast without SP after the (typename), i.e.

        gpointer *data = (gpointer *)user_data;

I've found a mixture of both in the code base, and the
CodingGuidelines doesn't say either way.  I'm happy to switch the file
to no SP after the typename if that's the project preference.

Somewhat arbitrary and unscientific, but between

    git grep -e '[^f]([a-z_ ]* \*)[^ ]' -- \*.c | wc -l
    422
    $ git grep -e '[^f]([a-z_ ]* \*) ' -- \*.c | wc -l
    233

I see that we favor "(struct blah *)apointer" over "(int *)
apointer".  Many hits in the latter grep come from compat/
that are borrowed pieces of code we tend not to style-fix.

The leading [^f] is crudely excludes "sizeof(typename *)"; it does
not change the resulting picture in a major way, though.

Thanks.