Thread (4 messages) flat view 4 messages, 4 authors, 2016-06-15

Re: git-submodule.sh respects submodule.$name.update in .git/config but not .gitmodules

From: Jens Lehmann <hidden>
Date: 2016-06-15 22:59:26

Am 12.12.2013 02:16, schrieb Junio C Hamano:
"W. Trevor King" [off-list ref] writes:
quoted
For
safety, maybe the default `init` should copy *everything* into
.git/config, after which users can remove stuff they'd like to
delegate to .gitmodules.
Copying everything into config is "be unsafe and inconvenient by
default for everybody", isn't it?  Folks who want safety are forced
to inspect the resulting entries in their config file (which is more
inconvenent if you compare with the design where nothing is copied
and nothing dynamically defaults to what then-current .gitmodules
happens to contain).  Folks who trust those who update .gitmodules
for them are forced to update their config every time upstream
decides to use different settings in .gitmodules, because they have
stale values in their config that mask what are in .gitmodules.

I think the solution we want is to copy only minimum to the config
(and that "minimum" may turn out to be "nothing"), and to default
keys that are only absolutely safe to .gitmodules file.
I agree and will prepare a patch for that.

What about teaching "git submodule sync" the "--url", "--update",
"--fetch", "--ignore", "--branch" and "--all" options to allow the
user to copy the current settings he wants from .gitmodules to
.git/config (but only safe values of course)? Trevor, would you be
ok to issue another command to copy everything to .git/config?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help