Re: [PATCH 4/5] gitweb: Add a feature for adding more branch refs
flat view
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:59:26
Jakub Narębski [off-list ref] writes:
With multi-valued we won't be able to override earlier / more generic
settings... well, unless we add support for no-value, or empty-value
as clearer, i.e.
[gitweb]
extrabranchrefs = sandbox
extrabranchrefs
# or extrabranchrefs =
extrabranchrefs = wip other
resulting in ('wip', 'other').Please don't, unless you are going to change the entire config machinery (including config.c bits that are used by the rest of the system) to follow such a convention to "clear settings so far read".
quoted
++ +It is an error to specify a ref that does not pass "git check-ref-format" +scrutiny. Duplicated values are filtered. +Hmmm... 'snapshot' feature ignores invalid values, but in this case formerly valid compression schemes might get invalid via tightening %known_snapshot_formats, and we don't want existing config getting suddenly invalid.
Sorry, but what does check-ref-format have to do with "formerly valid compression scheme that suddenly gets invalidated"???