Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/2] commit-slab: document clear_$slabname()

From: Thomas Rast <hidden>
Date: 2016-06-15 22:59:21

Jonathan Nieder [off-list ref] writes:
Thomas Rast wrote:
quoted
+ *
+ * - void clear_indegree(struct indegree *);
+ *
+ *   Free the slab's data structures.
Tense shift (previous descriptions were in the present tense, while
this one is in the imperative).

More importantly, this doesn't answer the questions I'd have if I were
in a hurry, which are what exactly is being freed (has the slab taken
ownership of any memory from the user, e.g. when elemtype is a
pointer?) and whether the slab needs to be init_ ed again.

Maybe something like the following would work?
[...]

Ok, I see that while I was procrastinating, you sorted this out and
Junio merged it to next.

Thanks, both.

-- 
Thomas Rast
tr@thomasrast.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help