Thread (21 messages) flat view 21 messages, 6 authors, 2018-08-03

Re: error: git-remote-https died of signal 13

From: Daniel Stenberg <hidden>
Date: 2016-06-15 22:59:19

On Mon, 25 Nov 2013, Jeff King wrote:
Thanks. I'm having trouble reproducing the SIGPIPE locally, but I am able to 
see via strace the write we make in curl_multi_cleanup. The call stack is:

 curl_multi_cleanup
   -> close_all_connections
     -> Curl_disconnect
       -> Curl_ossl_close
         ...

Daniel, does the call to Curl_disconnect need to be wrapped with 
sigpipe_ignore/reset, similar to 7d80ed64e435155?
Yes. It very much looks like that. The SSL "closing" is what was the problem I 
had to adress.

But I then decided that if a 3rd library has one way to generate SIGPIPE it 
may very well have another in a separate spot so I decided to do the wrap at 
the top level immediately in the entry point when getting called by the 
application. Following that, the SIGPIPE ignore/restore should rather be made 
in curl_multi_cleanup.

-- 

  / daniel.haxx.se
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help