Re: [PATCH v6 00/10] transport-helper: updates
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:59:13
Felipe Contreras [off-list ref] writes:
quoted hunk
Small changes since v5:diff --git a/builtin/fast-export.c b/builtin/fast-export.c index 8ed41b4..4b76222 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c@@ -736,9 +736,10 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix) usage_with_options (fast_export_usage, options); if (refspecs_list.nr) { - const char *refspecs_str[refspecs_list.nr]; + const char **refspecs_str; int i; + refspecs_str = xmalloc(sizeof(*refspecs_str) * refspecs_list.nr); for (i = 0; i < refspecs_list.nr; i++) refspecs_str[i] = refspecs_list.items[i].string;@@ -746,6 +747,7 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix) refspecs = parse_fetch_refspec(refspecs_nr, refspecs_str); string_list_clear(&refspecs_list, 1); + free(refspecs_str); } if (use_done_feature)diff --git a/git-remote-testgit.sh b/git-remote-testgit.sh index 716aa4c..1c006a0 100755 --- a/git-remote-testgit.sh +++ b/git-remote-testgit.sh@@ -15,6 +15,8 @@ test -z "$refspec" && prefix="refs" export GIT_DIR="$url/.git" +force= + mkdir -p "$dir" if test -z "$GIT_REMOTE_TESTGIT_NO_MARKS"
Looking good, modulo a few minor nits I noticed while comparing with the one that has been queued in 'pu', which I commented separately. Will re-queue. Thanks.