Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH v5 06/10] fast-export: add new --refspec option

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:59:11

On Wed, Nov 6, 2013 at 3:00 PM, Junio C Hamano [off-list ref] wrote:
Felipe Contreras [off-list ref] writes:
quoted
On Thu, Oct 31, 2013 at 12:26 PM, Junio C Hamano [off-list ref] wrote:
quoted
Felipe Contreras [off-list ref] writes:
quoted
+test_expect_success 'use refspec' '
+     git fast-export --refspec refs/heads/master:refs/heads/foobar master | \
+             grep "^commit " | sort | uniq > actual &&
It feels somewhat redundant that you have to twice say that you are
pushing your "master", once with --refspec and then the branch
name.  Is this the best we can do?
As this has been discussed before and no other solution came forward, yes.
We need to take that "no other solution came forward" with a grain
of salt.  After all, this is your itch, and if nobody was interested
in helping you (which I think that we both understand entirely
plausible, given the recent history), it only means you didn't think
of any other solution.
Thinking is easy, the problem is not thinking of a solution, the
problem is actually doing it. I think we should end world hunger. What
a great idea!
I didn't think things through, but at the external UI level, I see a
possibility of a nicer way to express the above.
You already said that before.

Talk is cheap. Show me the code.

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help