Re: [PATCH 06/16] shortlog: add missing declaration
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:59:09
Felipe Contreras [off-list ref] writes:
Otherwise we would have to include commit.h.
Was there a reason why commit.h is not included here, just like revision.h would include diff.h, so that users of shortlog.h do not have to worry about including commit.h themselves? Note: not requesting the patch to be changed; just inquiring the reasoning behind a different approach to solve related/same problem.
quoted hunk
Signed-off-by: Felipe Contreras <redacted> --- shortlog.h | 2 ++ 1 file changed, 2 insertions(+)diff --git a/shortlog.h b/shortlog.h index de4f86f..54bc07c 100644 --- a/shortlog.h +++ b/shortlog.h@@ -19,6 +19,8 @@ struct shortlog { struct string_list mailmap; }; +struct commit; + void shortlog_init(struct shortlog *log); void shortlog_add_commit(struct shortlog *log, struct commit *commit);