Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 20/19] count-objects: consider .bitmap without .pack/.idx pair garbage

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:59:08

Jeff King [off-list ref] writes:
On Sat, Oct 26, 2013 at 05:19:56PM +0700, Nguyen Thai Ngoc Duy wrote:
quoted
 Maybe squash this in some place, or leave it separate. I'm fine either way.
Thanks, this makes sense.  I've left it as a separate commit.

Your subject did not quite make sense to me, as the effect is to _not_
report .bitmap files as garbage. I updated the commit message to this:

    count-objects: recognize .bitmap in garbage-checking
    
    Count-objects will report any "garbage" files in the packs
    directory, including files whose extensions it does not
    know (case 1), and files whose matching ".pack" file is
    missing (case 2).  Without having learned about ".bitmap"
    files, the current code reports all such files as garbage
    (case 1), even if their pack exists. Instead, they should be
    treated as case 2.
Thanks; that reads well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help