Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: git-contacts questions

From: Sebastian Schuberth <hidden>
Date: 2016-06-15 22:59:07

On Tue, Oct 29, 2013 at 3:39 PM, Matthieu Moy
[off-list ref] wrote:
quoted
I'm not sure what you're trying to point me at. It's clear that from
an implementation view you need to blame HEAD^ if you need to know
which poeple should review your changes in HEAD.
I agree that the situation when providing only HEAD is really
disappointing...
quoted
But IMHO that is an implementation detail that should be hidden from
the user.
... but it's not just an implementation detail: git-contacts takes a
range of commits, so you can ask for people to Cc for a whole patch
series for example.

If I understand correctly, "git contact $ONE_COMMIT" does
"git contact $ONE_COMMIT..HEAD" implicitly, and this is weird when
$ONE_COMMIT is HEAD.
It's not only weird if $ONE_COMMIT is HEAD, but for any single commit.
At least I would expect "git contacts $ONE_COMMIT" to list the poeple
interested in the single commit $ONE_COMMIT. Instead, what it seems to
do is list the people who are interested in the commits *after*
$ONE_COMMIT.

-- 
Sebastian Schuberth
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help