Re: [PATCH] sha1_file: move comment about return value where it belongs

On Sun, Oct 27, 2013 at 12:34:30AM +0200, Christian Couder wrote:

Commit 5b0864070 (sha1_object_info_extended: make type calculation
optional, Jul 12 2013) changed the return value of the
sha1_object_info_extended function to 0/-1 for success/error.

Previously this function returned the object type for success or
-1 for error. But unfortunately the above commit forgot to change
or move the comment above this function that says "returns enum
object_type or negative".

To fix this inconsistency, let's move the comment above the
sha1_object_info function where it is still true.

Thanks for catching this. Your analysis and patch looks good to me.

-Peff