Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

From: Duy Nguyen <hidden>
Date: 2016-06-15 22:58:57

On Tue, Oct 8, 2013 at 3:44 PM, Carlos Martín Nieto [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/send-pack.c b/send-pack.c
index 7d172ef..7b88ac8 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -205,6 +205,8 @@ int send_pack(struct send_pack_args *args,
                quiet_supported = 1;
        if (server_supports("agent"))
                agent_supported = 1;
+       if (!server_supports("thin-pack"))
+               args->use_thin_pack = 0;
Hmm.. I think this introduces a regression in C Git because
receive-pack never advertises "thin-pack" and so "git push" from now
on will never send thin packs. It's too late now to add thin-pack to
receive-pack, perhaps a new extension "no-thin-pack" for those
servers? Alternatively, just run git push --no-thin (you'll need
f7c815c (push: respect --no-thin - 2013-08-12) though).
        if (!remote_refs) {
                fprintf(stderr, "No refs in common and none specified; doing nothing.\n"
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help