Re: [PATCH] build: add default configuration

Felipe Contreras [off-list ref] wrote:

David Aguilar wrote:

quoted

Felipe Contreras [off-list ref] wrote:

quoted

On Wed, Sep 18, 2013 at 9:30 PM, David Aguilar [off-list ref]
wrote:

quoted

quoted

On Wed, Sep 18, 2013 at 1:13 PM, David Aguilar [off-list ref]

wrote:

quoted

quoted

quoted

Will this not conflict with folks that supply their own

gitconfig?

quoted

quoted

quoted

quoted

You mean people that provide their own ETC_GITCONFIG? If you mean

distributions, their packaging would override /etc/gitconfig, if

you

quoted

quoted

quoted

mean people that have already a /etc/gitconfig, packaging systems
usually save the old one so they can solve the conflict manually

(e.g.

quoted

/etc/gitconfig.pacsave). So no, it would not conflict.

Yuck. Yes, that one. I package my own /etc/gitconfig (as we have

long

quoted

quoted

advertised as the "way to do it")

You package /etc/gitconfig *outside* the git package? I don't see

how

quoted

quoted

that could have been ever advertised as the way to do it.

Okay so how exactly are we supposed to do it?  Duh, rpm is the right

choice for redhat systems. 

The same way kerberos, mariadb, apache, and essentially every other
tool that
has a configuration file in /etc.

Good point. These tools (apache, for example) allow inclusion of a directory. Users are encouraged to package their stuff inside eg httpd.d/, and the distros ship a neutral config that includes that directory. 

Your patch does not add this capability, so by your own definition it's incomplete.  As-is, the patch is half-baked.

If we have a clear upgrade path -- eg "move your current configs over to /etc/git.d/your.conf" -- then it's a non-issue. 

As-is, you're asking users to manually deal with the fallout. You're also asking users to modify a package-manager controlled file (after your patch), which IMO is suboptimal. 

quoted

quoted

Users don't package /etc/gitconfig outside git.

Wrong. Existence proof: me. 

You as a user are not packaging it, it's you as a system adimistrator.

Strawman. I represent at least at least a hundred users, but who cares. It doesn't matter.  The patch is incomplete. 

Either
way, you are 0.0001% of Git's userbase, you are not representative.

And your point is what exactly?  That once proven wrong you move the goalposts?

quoted

quoted

quoted

quoted

quoted

I like the idea. Docs?  Also, should this not be done in the C

side

quoted

quoted

so that we don't waste time reading the config, and also prevent

users

quoted

quoted

from overriding these?

quoted

quoted

But we want them to be easily readable, and possibly allow

distributions to easily modify them.

In that case I take it back -- I dont like that approach.  We want

consistency, not divergence. This encourages the former.

So you think we have more consistency right now? We don't even have

a

quoted

quoted

predefined /etc/gitconfig, that creates more inconsistency, as
everybody's configs and aliases are very very different.

This patch would definitely make things more consistent.

We don't need this patch to allow distros to modify aliases.

Likewise, allowing the aliases to diverge is less consistent. Do it at
a lower level. 

We already allow the aliases to diverge, we allow it much more.

The pach will make the aliases more consistent.

quoted

I also agree with Junio's notes about "ci". Something short that can

add and remove from the index would be nice. 

cvs ci, svn ci, hg ci, they all work, but suddenly ci is not good
enough for Git? Yeah, sure.

IMO this isn't the kind of thing that you or I can decide in isolation.  Maybe it is, or maybe the real differences between the "ci" mental model are enough that it isn't. But you don't actually know the answer. You might think you do, but your guess is just as good/bad/ugly as mine. 

-- 
David

-- 
You received this message because you are subscribed to the Google Groups "Git for human beings" group.
To unsubscribe from this group and stop receiving emails from it, send an email to git-users+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/groups/opt_out.