Re: [PATCH] sequencer: trivial cleanup
From: Felipe Contreras <hidden>
Date: 2016-06-15 22:58:41
On Sun, Sep 8, 2013 at 5:42 PM, Ramkumar Ramachandra [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Ramkumar Ramachandra <redacted> --- sequencer.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/sequencer.c b/sequencer.c index 351548f..8ed9f98 100644 --- a/sequencer.c +++ b/sequencer.c@@ -466,10 +466,7 @@ static int allow_empty(struct replay_opts *opts, struct commit *commit) empty_commit = is_original_commit_empty(commit); if (empty_commit < 0) return empty_commit; - if (!empty_commit) - return 0; - else - return 1; + return empty_commit ? 0 : 1; }
Isn't it the other way around? Moreover, 'return !!empty_commit;' would be simpler. -- Felipe Contreras