Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v5 1/7] replace: forbid replacing an object with one of a different type

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:39

Junio C Hamano [off-list ref] writes:
Christian Couder [off-list ref] writes:
quoted
+	obj_type = sha1_object_info(object, NULL);
+	repl_type = sha1_object_info(repl, NULL);
That we can do this is somewhat curious....
Note that this was a comment on the sha1_object_info() API, which,
unlike read_sha1_file() API, does not seem to interact with the
"replace" mechanism.  I _think_ that needs to be rethought by
checking each call site, but for the purpose of this series, I think
this is the best we can do in this patch.

Will queue the whole series.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help