Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

I did. I just clumsily sent out the wrong patch. I.e. tested it
manually on another system, and then fat-fingered $fh instead of $fd.

Should I send another patch or do you want to just fix this one up?

On Fri, Aug 30, 2013 at 8:13 PM, Junio C Hamano [off-list ref] wrote:

Junio C Hamano [off-list ref] writes:

quoted

Ævar Arnfjörð Bjarmason  [off-list ref] writes:

quoted

Acked-by: Jakub Narębski <redacted>
Tested-by: Ævar Arnfjörð Bjarmason <redacted>
Tested-by: Simon Ruderich <redacted>
---

+++ b/gitweb/gitweb.perl

@@ -6631,6 +6631,7 @@ sub git_blame_common {

...
+    binmode $fh, ':utf8';

quoted

[Fri Aug 30 17:48:17 2013] gitweb.perl: Global symbol "$fh" requires
explicit package name at /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl line 6634.
[Fri Aug 30 17:48:17 2013] gitweb.perl: Execution of /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl aborted due to compilation errors.

I think in this function the filehandle is called $fd, not $fh.  Has
any of you really tested this???