[PATCH v6 11/28] cherry-pick: copy notes and run hooks
From: Felipe Contreras <hidden>
Date: 2016-06-15 22:58:34
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
If no action-name is specified, nothing is done. Signed-off-by: Felipe Contreras <redacted> --- Documentation/config.txt | 9 ++++----- Documentation/githooks.txt | 8 ++++---- rewrite.c | 1 + sequencer.c | 25 ++++++++++++++++++++++++- 4 files changed, 33 insertions(+), 10 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index ec57a15..7e7f89f 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt@@ -1691,11 +1691,10 @@ GIT_NOTES_REF) is also implicitly added to the list of refs to be displayed. notes.rewrite.<command>:: - When rewriting commits with <command> (currently `amend` or - `rebase`) and this variable is set to `true`, Git - automatically copies your notes from the original to the - rewritten commit. Defaults to `true`, but see - "notes.rewriteRef" below. + When rewriting commits with <command> (currently `amend`, `rebase`, or + `cherry-pick`) and this variable is set to `true`, Git automatically + copies your notes from the original to the rewritten commit. Defaults + to `true`, but see "notes.rewriteRef" below. notes.rewriteMode:: When copying notes during a rewrite (see the
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index d48bf4d..8cfa13b 100644
--- a/Documentation/githooks.txt
+++ b/Documentation/githooks.txt@@ -352,10 +352,10 @@ post-rewrite ~~~~~~~~~~~~ This hook is invoked by commands that rewrite commits (`git commit ---amend`, 'git-rebase'; currently 'git-filter-branch' does 'not' call -it!). Its first argument denotes the command it was invoked by: -currently one of `amend` or `rebase`. Further command-dependent -arguments may be passed in the future. +--amend`, `git rebase`, `git cherry-pick`; currently `git filter-branch` does +'not' call it!). Its first argument denotes the command it was invoked by +(e.g. `rebase`). Further command-dependent arguments may be passed in the +future. The hook receives a list of the rewritten commits on stdin, in the format
diff --git a/rewrite.c b/rewrite.c
index 4dddcd9..4f95094 100644
--- a/rewrite.c
+++ b/rewrite.c@@ -2,6 +2,7 @@ #include "rewrite.h" #include "run-command.h" #include "notes-utils.h" +#include "builtin.h" void add_rewritten(struct rewritten *list, unsigned char *from, unsigned char *to) {
diff --git a/sequencer.c b/sequencer.c
index 46848c4..076bb9d 100644
--- a/sequencer.c
+++ b/sequencer.c@@ -22,6 +22,22 @@ const char sign_off_header[] = "Signed-off-by: "; static const char cherry_picked_prefix[] = "(cherry picked from commit "; static struct rewritten rewritten; +static void finish(struct replay_opts *opts) +{ + const char *name; + + if (opts->action != REPLAY_PICK) + return; + + name = opts->action_name ? opts->action_name : "cherry-pick"; + + if (!*name) + return; + + copy_rewrite_notes(&rewritten, name, "Notes added by 'git cherry-pick'"); + run_rewrite_hook(&rewritten, name); +} + static int is_rfc2822_line(const char *buf, int len) { int i;
@@ -1033,6 +1049,8 @@ static int pick_commits(struct commit_list *todo_list, struct replay_opts *opts) } } + finish(opts); + /* * Sequence of picks finished successfully; cleanup by * removing the .git/sequencer directory
@@ -1104,8 +1122,13 @@ static int sequencer_skip(struct replay_opts *opts) static int single_pick(struct commit *cmit, struct replay_opts *opts) { + int ret; setenv(GIT_REFLOG_ACTION, action_name(opts), 0); - return do_pick_commit(cmit, opts); + ret = do_pick_commit(cmit, opts); + if (ret) + return ret; + finish(opts); + return 0; } int sequencer_pick_revisions(struct replay_opts *opts)
--
1.8.4-fc