Thread (20 messages) 20 messages, 4 authors, 2016-06-15

Re: [RFC PATCH] During a shallow fetch, prevent sending over unneeded objects

From: Matthijs Kooijman <hidden>
Date: 2016-06-15 22:58:32

Possibly related (same subject, not in this thread)

Hi Duy,
I thought a bit but my thoughts often get stuck if I don't write them
down in form of code :-) so this is what I got so far. 4/6 is a good
thing in my opinion, but I might overlook something 6/6  is about this
thread.
The series looks good to me, though I don't know enough about the code
to do detailed analysis.

In any case, I agree that 4/6 is a good change, it removes a bunch of
similar code for the shallow special case (which is now no longer a
completely separate special case).

The total series also seems to actually fix the problem I reported. I'll
resend the testcase from my original patch as well, which now passes
with your series applied.

Thanks for diving into this!

Gr.

Matthijs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help