Re: [PATCH 01/23] pack v4: initial pack dictionary structure and code

On Tue, 27 Aug 2013, Junio C Hamano wrote:

Nicolas Pitre [off-list ref] writes:

quoted

Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
---

Was there a reason not to reuse the hash-table Linus did in
hash.[ch]?

Well... Most likely because when I started that code (which used to be 
quite different initially) it might not have been served correctly by 
hash.c, or any other reasons I long have forgotten by now which might or 
might not still be valid.

It may not make much of a difference for something so small and
isolated from the rest of the system, but if hash.[ch] can be easily
fixed with a small tweak to suit the use by this subsystem better,
it might be worth reusing the existing code with improvement, which
may help other potential users.

Absolutely.  If someone wants to give a hand in that direction I'll 
happily integrate patches into my series.  I cannot promise I'll do the 
work myself as I prefer spending the time I have available on actually 
making pack v4 usable.


Nicolas