Re: [PATCH 2/2] grep: use slash for path delimiter, not colon

On Mon, Aug 26, 2013 at 4:13 PM, Johannes Sixt [off-list ref] wrote:

Am 26.08.2013 21:56, schrieb Jeff King:

quoted

Also, prevent the delimiter being added twice, as happens now in these
examples:

  git grep -l foo HEAD:
  HEAD::some/path/to/foo.txt
       ^

Which one of these two does it print then?

    HEAD:/some/path/to/foo.txt
    HEAD:some/path/to/foo.txt

With my patch it prints the latter.

This is because get_sha1_with_context("HEAD:"...) returns an empty
'path' string.  The code decides to use ':' as the delimiter in that
case, but it sees there already is one at the end of "HEAD:".

Phil