Thread (5 messages) flat view 5 messages, 2 authors, 2016-06-15

Re: [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/'

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:58:30

Eric Sunshine wrote:
Although undocumented, directory_exists_in_index_icase(dirname,len)
unconditionally assumes the presence of a '/' at dirname[len] (despite
being past the end-of-string). Callers are expected to respect
[...]
                                               Fix this problem.
So, does this fix the problem by changing
directory_exists_in_index_icase() to be more liberal in what it
accepts, or callers to be more conservative in what they pass in?

Please forgive my laziness.  I ask in order to save future readers the
time of digging into the code.

Thanks,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help