Thread (5 messages) flat view 5 messages, 4 authors, 2016-06-15

Re: [RFC/PATCH] Fix path prefixing in grep_object

From: Phil Hord <hidden>
Date: 2016-06-15 22:58:30

On Sat, Aug 24, 2013 at 9:35 PM, Phil Hord [off-list ref] wrote:
When the pathspec given to grep includes a tree name, the full
name of matched files is assembled using colon as a separator.
If the pathspec includes a tree name, it should use a slash
instead.

Check if the pathspec already names a tree and ref (including
a colon) and use a slash if so.
I think I used lots of wrong terminology there.  What do I call these
things?

HEAD:path is a tree.

HEAD is a commit name.

Maybe like this?

  When a tree is given to grep, the full name of matched files
  is assembled using colon as a separator.

  If the tree name includes an object name, as in
  HEAD:some/path, it should use a slash instead.

Phil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help