Re: [PATCH 1/2] t3103: demonstrate dir.c:treat_one_path() core.ignorecase failure
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:29
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH 1/2] t3103: demonstrate dir.c:treat_one_path() core.ignorecase failure · Eric Sunshine <hidden>
Eric Sunshine [off-list ref] writes:
quoted hunk
@@ -21,4 +22,18 @@ test_expect_success 'ls-tree fails with non-zero exit code on broken tree' ' test_must_fail git ls-tree -r HEAD ' +test_expect_failure 'ls-tree directory core.ignorecase' ' + cat >expect <<-\EOF && + d/e/f + EOF + mkdir d && + >d/e && + git update-index --add -- d/e && + rm d/e && + mkdir d/e && + >d/e/f && + git -c core.ignorecase=true ls-files -k >actual && + test_cmp expect actual +'
Hmm. Wouldn't it be a clearer demonstration to add to t3010 another invocation of "ls-files -k" that was added by 3c568751 (t3010: update to demonstrate "ls-files -k" optimization pitfalls, 2013-08-15) but with core.ignorecase=true? Something like... t/t3010-ls-files-killed-modified.sh | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/t/t3010-ls-files-killed-modified.sh b/t/t3010-ls-files-killed-modified.sh
index 6ea7ca8..f4783ed 100755
--- a/t/t3010-ls-files-killed-modified.sh
+++ b/t/t3010-ls-files-killed-modified.sh@@ -90,6 +90,17 @@ pathx/ju/nk EOF test_expect_success \ + 'git ls-files -k to show killed files (with icase)' \ + 'git -c core.ignorecase=true ls-files -k >.output' +cat >.expected <<EOF +path0/file0 +path1/file1 +path2 +path3 +pathx/ju/nk +EOF + +test_expect_success \ 'validate git ls-files -k output.' \ 'test_cmp .expected .output'