Thread (20 messages) flat view 20 messages, 5 authors, 2016-06-15

Re: [PATCH 2/4] index-pack: optionally reject packs with duplicate objects

From: Duy Nguyen <hidden>
Date: 2016-06-15 22:58:29

On Thu, Aug 22, 2013 at 3:52 AM, Jeff King [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -68,6 +81,16 @@ const char *write_idx_file(const char *index_name, struct pack_idx_entry **objec
        else
                sorted_by_sha = list = last = NULL;

+       if (opts->duplicates == WRITE_IDX_DUPLICATES_REJECT) {
+               struct pack_idx_entry **dup;
+
+               dup = find_duplicate(sorted_by_sha, nr_objects,
+                                    sizeof(*sorted_by_sha), sha1_compare);
+               if (dup)
+                       die("pack has duplicate entries for %s",
+                           sha1_to_hex((*dup)->sha1));
+       }
+
        if (opts->flags & WRITE_IDX_VERIFY) {
                assert(index_name);
                f = sha1fd_check(index_name);
write_idx_file() is called after index-pack processes all delta
objects. Could resolve_deltas() go cyclic with certain duplicate
object setup?
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help