Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] Document the HTTP transport protocols

From: Duy Nguyen <hidden>
Date: 2016-06-15 22:58:29

On Thu, Aug 22, 2013 at 5:00 AM, Jeff King [off-list ref] wrote:
On Wed, Aug 21, 2013 at 08:45:13PM +0700, Nguyen Thai Ngoc Duy wrote:
quoted
 On the topic, C Git's (maybe) violations on this spec are:

  - The client does not strip trailing slashes from $GIT_URL before
    sending to the server, as described in section "URL Format".
Yeah. We get the basic gist right by not adding an extra "/" if there is
already a trailing slash (so you do not have http://host/path//info/refs").
But we do not go out of our way to remove multiple slashes that the user
hands out (either at the end or in the middle of the URL). I doubt that
it matters in practice.
It may make writing rewrite/matching patterns in http server a tiny
bit harder, but should not be a big deal. I agree with Junio this
could be something a new contributor can work on to get familiar with
(scary, imo) transport/connect code.

I agree with the rest of your comments that those "violations" do not
matter much (when I raised them I did not mean "fix Git", just
checking if I missed anything) and the document is ok as-is.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help