Re: [RFC PATCHv6 1/2] repack: rewrite the shell script in C

Am 22.08.2013 00:15, schrieb Stefan Beller:

On 08/21/2013 10:56 PM, Junio C Hamano wrote:

quoted

Stefan Beller [off-list ref] writes:

quoted

+static int delta_base_offset = 1;
+char *packdir;

Does this have to be global?

As the path is pretty obvious (get_object_directory() + "/pack"),
we could however also construct it again in the signal handler.

I would advise against doing that. The recomputation would call malloc(), 
which is not async-signal-safe. (It would not be the first case where we 
call "forbidden" functions from signal handlers, but we need not pile more 
on top of them.)

-- Hannes