Thread (11 messages) flat view 11 messages, 5 authors, 2016-06-15

Re: [PATCH] create_delta_index: simplify condition always evaluating to true

From: Eric Sunshine <hidden>
Date: 2016-06-15 22:58:26

On Fri, Aug 16, 2013 at 7:43 AM, brian m. carlson
[off-list ref] wrote:
On Thu, Aug 15, 2013 at 09:37:40PM +0200, Stefan Beller wrote:
quoted
When checking the previous lines in that function, we can deduct that
hsize must always be smaller than (1u<<31), since 506049c7df2c6
(fix >4GiB source delta assertion failure), because the entries is
the entries are
'entries' is a variable name, thus singular. Stefan corrected it in v2
to say "because entries is capped..." (though it would have been even
a bit clearer to add quotes around 'entries').
quoted
capped at an upper bound of 0xfffffffeU, so hsize contains a maximum
value of 0x3fffffff, which is smaller than (1u<<31), so i will never
be larger than 31.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help