Re: [RFC PATCH] repack: rewrite the shell script in C.

Antoine Pelisse [off-list ref] writes:

On Wed, Aug 14, 2013 at 6:27 PM, Stefan Beller
[off-list ref] wrote:

quoted

 builtin/repack.c               | 410 +++++++++++++++++++++++++++++++++++++++++
 contrib/examples/git-repack.sh | 194 +++++++++++++++++++
 git-repack.sh                  | 194 -------------------

I'm still not sure I understand the trade-off here.

Most of what git-repack does is compute some file paths, (re)move
those files and call git-pack-objects, and potentially
git-prune-packed and git-update-server-info.
Maybe I'm wrong, but I have the feeling that the correct tool for that
is Shell, rather than C (and I think the code looks less intuitive in
C for that matter).
I'm not sure anyone would run that command a thousand times a second,
so I'm not sure it would make a real-life performance difference.

I do not think the motivation of this patch is about performance in
the first place, though.

Last and very less important: I think it's OK to format-patch with -M,
especially when you move a file.

Cheers,
Antoine