Re: [PATCH] unpack-trees: plug a memory leak

Am 13.08.2013 23:12, schrieb Junio C Hamano:

René Scharfe [off-list ref] writes:

quoted

From: Felipe Contreras <redacted>

Before overwriting the destination index, first let's discard its
contents.

Signed-off-by: Felipe Contreras <redacted>
Tested-by: Лежанкин Иван <redacted> wrote:
---
Felipe sent this patch as part of multiple series in June, but it can
stand on its own.  This version is trivially rebased against master.
The leak seems to have been introduced by 34110cd4 (2008-03-06,
"Make 'unpack_trees()' have a separate source and destination index").

It was lost in the follow-up discussion and I missed it.

I had forgotten about it as well, until Felipe mentioned it again.

I assume that this is signed-off by you as a forwarder?  I'd prefer
to even mark it Reviewed-by: you.

Right, I did review the patch and you can tag it as such.

Thanks,
René