Thread (5 messages) 5 messages, 2 authors, 2016-06-15

Re: [PATCH] pull: Allow pull to preserve merges when rebasing.

From: Stephen Haberman <hidden>
Date: 2016-06-15 22:58:24

Hi Andres,
i just realized that there are ambiguities:
pull --rebase (true|false|preserve) foo # pull from remote named
(true|false|preserve), branch foo
Yeah.

Right now, I did the latter. Around line 125, when parsing "--rebase
<somearg>", we accept <somearg> only if it's true, false, or preserve,
and shift it off. Otherwise we leave it alone and assume it's a remote
name.

Without this logic, t5520 fails because it uses "git pull --rebase .
copy", which, as you noted, is ambiguous, so "." was showing up as the
rebase argument.

So, this is technically handled right now, but I'm fine removing the
ambiguous "--rebase true|false|preserve" option if that is what is
preferred.

- Stephen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help