Re: [GUILT] add FreeBSD support

On Fri, Aug 09, 2013 at 11:04:45PM +0800, gnehzuil.liu wrote:

�� 2013-8-9������10:46��Josef 'Jeff' Sipek [off-list ref] ���

quoted

On Fri, Aug 09, 2013 at 08:32:28PM +0800, Zheng Liu wrote:

quoted

From: Zheng Liu <redacted>

Currently guilt doesn't support FreeBSD platform.  This commit tries to
add this support.  The file called 'os.FreeBSD' is copied from os.Darwin
due to these two platforms have almost the same command tools.

Out of curiosity, is it identical?  I eyeballed it, and they do look
identical.  There's probably a better way to do this whole os-specific
thing, but this will work well enough for now.

Yes, it is identical.  Sorry, I am a newbie for guilt, but I am happy to
improve this os-specific thing.    Any idea?

So, I'm a bit torn between some "build-time" checking that generates
something like an "os" file based on what it detects and something that
happens at runtime.  I like that currently there's nothing to do - you just
clone the repo and you're set.  At the same time, the more code can be
avoided executing the faster (in theory) guilt gets.

Feel free to experiment.

Jeff.

-- 
The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man.
		- George Bernard Shaw