Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] die_with_status: use "printf '%s\n'", not "echo"

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:58:21

Possibly related (same subject, not in this thread)

Thomas Rast [off-list ref] writes:
quoted
+	grep -v "	" error
Umm, doesn't that only test that _some_ line in the error does not
contain a tab?
Indeed. It does work as the error message is just a one-liner, but let's
be robust anyway.
Whereas you need to test that _no_ line contains <TAB>emp, or some
such.  Perhaps as

  ! grep -v "	emp" error
Err, then the -v should be remove. Also, I'll use test_expect_code 1
instead of ! to catch other grep failures, just in case.

Thanks, new patch comming.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help