Thread (13 messages) flat view 13 messages, 3 authors, 2016-06-15

Re: [PATCH v6 2/6] config: add helper to normalize and match URLs

From: Kyle J. McKay <hidden>
Date: 2016-06-15 22:58:17

On Jul 31, 2013, at 12:26, Junio C Hamano wrote:
From: "Kyle J. McKay" <redacted>

Some http.* configuration variables need to take values customized
for the URL we are talking to.  We may want to set http.sslVerify to
true in general but to false only for a certain site, for example,
with a configuration file like this:
[...]
quoted hunk ↗ jump to hunk
urlmatch.c | 468 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 
+++++++++
urlmatch.h |  36 +++++
2 files changed, 504 insertions(+)
create mode 100644 urlmatch.c
create mode 100644 urlmatch.h
diff --git a/urlmatch.c b/urlmatch.c
new file mode 100644
index 0000000..e1b03ee
--- /dev/null
+++ b/urlmatch.c
[...]
+
+static size_t http_options_url_match_prefix(const char *url,
+					    const char *url_prefix,
+					    size_t url_prefix_len)
+{
+	/*
+	 * url_prefix matches url if url_prefix is an exact match for url  
or it
+	 * is a prefix of url and the match ends on a path component  
boundary.
+	 * Both url and url_prefix are considered to have an implicit '/'  
on the
+	 * end for matching purposes if they do not already.
This function should probably be renamed to just url_match_prefix  
since it isn't part of nor does it depend on the http_options related  
files or functions anymore.

Otherwise looks good to me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help