Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 0/3] Remove sq_quote_print() in favor of *_buf

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:16

Ramkumar Ramachandra [off-list ref] writes:
While going through the for-each-ref-pretty series that Duy and I were
developing, I noticed that this cleanup was independent and good
as-it-is.

So here it is.
You always can first allocate a piece of memory and write into it
instead of writing things out directly.  The patch shows it _can_ be
done, but that is not a news.

And such a change is hardly a "clean-up".  It just wastes more
memory you do not have to waste, in order to do what you are doing.

When there is a reason why you need an in-memory representation,
this change starts to become the first step refactoring for an
enhancement.
Nguyễn Thái Ngọc Duy (1):
  for-each-ref, quote: convert *_quote_print -> *_quote_buf
The log message for this one explains it very well.  This change by
itself is not useful, but it will become necessary once you start
needing to access an in-memory result.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help