Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v6 2/4] config: improve support for http.<url>.* settings

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:13

"Kyle J. McKay" [off-list ref] writes:
If you mean for all the strchr etc. calls, multiple tables would be
required since URL_SCHEME_CHARS and URL_HOST_CHARS partially overlap,
The entries of the table could be at least 8-bit wide, so there
shouldn't be any problem, should there?
but it could be done.  Is the speed of strchr that much of a concern?
The code will only be invoked for http.<url>.* option settings in any
case and I expect the user would have to set an awfully large number
of those to even begin to notice.
We can start slow and then optimize, but I suspect that there are
sufficient number of people who are into micro-optimizing, and such
a slow implementation may quickly be replaced.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help