Re: [PATCH v5 4/5] config: improve support for http.<url>.* settings

On Tue, Jul 16, 2013 at 5:53 AM, Kyle J. McKay [off-list ref] wrote:

On Jul 15, 2013, at 16:12, Eric Sunshine wrote:

quoted

On Mon, Jul 15, 2013 at 5:51 AM, Kyle J. McKay [off-list ref] wrote:

quoted

+static int append_normalized_escapes(struct strbuf *buf,
+                                    const char *from,
+                                    size_t from_len,
+                                    const char *esc_extra,
+                                    const char *esc_ok)
+{
+       /*
+        * Append to strbuf buf characters from string from with length
from_len

s/from string from/from string/

Hmmm.  Actually it's meant to say "from string <parameter with name from>".

Do quotes make it read better:

  from string `from'

Or do you think it needs to be:

  from string parameter `from'

Ah, I see now. Thanks for clarifying. Quoting 'from' (and the other
arguments) probably would make it sufficiently readable.