Re: Bug in .mailmap handling?

Junio C Hamano [off-list ref] writes:

Stefan Beller [off-list ref] writes:

quoted

	git shortlog -sne
		 1  A [off-list ref]
		 1  A [off-list ref]

This is coming from mailmap.c::add_mapping() that downcases the
e-mail address.

changed_email@example.org is mapped to a@example.org because of this
downcasing, while "A [off-list ref]" does not have any entry for it
in the .mailmap file, so it is given back as-is.  Hence we see two
distinct entries.

I think it is wrong for the parser to lose information by
downcasing.

It is perfectly fine to do the comparison case insensitively, to
allow [off-list ref] in the input is mangled using the
entry for [off-list ref] in the .mailmap file; it is
not fine to downcase the parsed result, especially the side that is
used as the "rewritten result" (i.e. the tokens earlier on the line),
as that would mean mangling the output.

Let me see if I can quickly whip up a fix.