Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v4] config: add support for http.<url>.* settings

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:08

"Kyle J. McKay" [off-list ref] writes:
+	if (!strcmp("sslcertpasswordprotected", key)) {
+		if (check_matched_len(opt_passwd_req, matchlen))
+			return 0;
 		if (git_config_bool(var, value))
 			ssl_cert_password_required = 1;
 		return 0;
 	}
This is not a new problem, but I think the existing code is wrong.
There is no way to countermand an earlier

	[http]
        	sslcertpasswordprotected

in a more generic configuration file with


	[http]
        	sslcertpasswordprotected = no

in a repository specific configuration file.

Perhaps we should fix it as a preparatory patch (1/2) before the
main "feature addition" patch.
-	if (!strcmp("http.ssltry", var)) {
+	if (!strcmp("ssltry", key)) {
+		if (check_matched_len(opt_ssl_try, matchlen))
+			return 0;
 		curl_ssl_try = git_config_bool(var, value);
 		return 0;
 	}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help