Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/2] t9902: fix 'test A == B' to use = operator

From: Thomas Rast <hidden>
Date: 2016-06-15 22:58:03

Junio C Hamano [off-list ref] writes:
Thomas Rast [off-list ref] writes:
quoted
The == operator as an alias to = is not POSIX.  This doesn't actually
matter for the execution of the script, because it only runs when the
shell is bash.  However, it trips up test-lint, so it's nicer to use
the standard form.
OK, my knee-jerk reaction was "this is only for bash" as you said,
but the test-lint part I agree with.

But then test-lint _ought_ to also catch the use of "local" in the
ideal world, so perhaps in the longer term we would need to treat
this bash-only script differently from others anyway???
True.  I didn't really think about wider implications; I just noticed
that there was an easy-to-fix complaint from test-lint :-)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help