Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3 0/2] allow git-svn fetching to work using serf

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:02

"Kyle J. McKay" [off-list ref] writes:
From: "Kyle J. McKay" <redacted>

This patch allows git-svn to fetch successfully using the
serf library when given an https?: url to fetch from.

Unfortunately some svn servers do not seem to be configured
well for use with the serf library.  This can cause fetching
to take longer compared to the neon library or actually
cause timeouts during the fetch.  When timeouts occur
git-svn can be safely restarted to fetch more revisions.

A new temp_is_locked function has been added to Git.pm
to facilitate using the minimal number of temp files
possible when using serf.

The problem that occurs when running git-svn fetch using
the serf library is that the previously used temp file
is not always unlocked before the next temp file needs
to be used.

To work around this problem, a new temp name is used
if the temp name that would otherwise be chosen is
currently locked.

Version v2 of the patch introduced a bug when changing the _temp_cache
function to use the new temp_is_locked function at the suggestion of a
reviewer.  That has now been resolved.
Thanks; I've queued this version to 'pu' at least tentatively.

Is everybody who discussed the issue happy with the direction of
this patch?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help