Thread (6 messages) flat view 6 messages, 2 authors, 2016-06-15

Re: [PATCH 1/3] name-rev: fix assumption about --name-only usage

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 22:58:02

Junio C Hamano wrote:
quoted
would get name-rev to print output in the same format as describe,

  $ git describe --contains --all v1.8.3~1
  tags/v1.8.3~1

would not strip the leading "tags/".
If you _know_ v1.8.3 does not appear outside "tags/", this does look
inconsistent, but I do not think the code checks it.  Ahd if the
code does not, I am not sure not stripping "tags/" is necessarily a
bad thing, because "--all" allows names to come outside "tags/"
hierarchy.
Yeah, you asked for it using --all.
Also how should this interact with v1.8.3-1-g98c5c4a that changed
the rule somewhat so that the common prefix is stripped when we know
the result is not ambiguous?
Completely independent of everything else.  The condition is "if
name-only && prefix == refs/tags", strip that prefix.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help