Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] prompt: do not double-discriminate detached HEAD

From: Eduardo R. D'Avila <hidden>
Date: 2016-06-15 22:58:02

I think color in terminals should be used to highlight and make it easier to see
textual information, not to replace them. So I would keep the parenthesis.
+                               test -n "${GIT_PS1_SHOWCOLORHINTS-}" || b="($b)"
Also, the proposed change has a side-effect because color is not possible in
non-pc mode, even if GIT_PS1_SHOWCOLORHINTS is defined. (Non-pc mode
with GIT_PS1_SHOWCOLORHINTS defined would make the detached HEAD not be
shown neither in red nor within parenthesis).

Regards,

Eduardo R. D'Avila
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help