Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v10 3/5] t4205, t6006, t7102: make functions better readable

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:58:00

Junio C Hamano [off-list ref] writes:
Alexey Shumkin [off-list ref] writes:
quoted
-	msg=$(printf "modify 2nd file (ge\303\244ndert)")
+	msg="modify 2nd file (ge\303\244ndert)"
 	if test -n "$1"
 	then
-		msg=$(echo $msg | iconv -f utf-8 -t $1)
+		print "$msg" | iconv -f utf-8 -t "$1"
+	else
+		print "$msg"
 	fi
-	echo $msg
 }
I think I'll do s/print/&f/ before queuing this.
Also, I'll change the $msg constant to have \n at the end, as we are
losing it by bypassing "echo".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help