Jeff King [off-list ref] writes:
You lose the assertion that finalize_deferred_config has been called,
but I think the resulting code would be simpler, as it drops this
die("BUG") state entirely. Am I missing something?
Probably not. Depending on "-z", NONE is sometimes converted to
PORCELAIN and sometimes left as-is. I originally wanted to keep the
"unspecified" state as long as possible so that this deferred config
logic and the "-z" default logic can be kept separate.
The final patch ended up folding that "-z" default logic into the
same function, so it probably is saner to remove UNSPECIFIED.